Reuse managedMonitorDatabase to validate the canonical target-owned database and private files/sidecars before openStore can create, chmod or migrate anything. Keep ordinary history read-only and experimental authorization unchanged. Cover unsafe paths, links, modes, owners and sidecars plus valid existing stores. Co-authored-by: GPT-6 <gpt-6@openai.com>
146 lines
4.0 KiB
Go
146 lines
4.0 KiB
Go
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"os"
|
|
"path/filepath"
|
|
"syscall"
|
|
"testing"
|
|
)
|
|
|
|
func managedWriterFixture(t *testing.T) (managedDeps, map[string]string) {
|
|
t.Helper()
|
|
d, env, _ := managedCLIFixture(t)
|
|
env["ZAPRET_AUTOTUNE_DB"] = managedTargetDirectory + "/candidates.db"
|
|
d.openWriteDB = managedDependencies(nil).openWriteDB
|
|
return d, env
|
|
}
|
|
|
|
func TestManagedCandidateWriterPreservesReadOnlyHistory(t *testing.T) {
|
|
d, _ := managedWriterFixture(t)
|
|
path := filepath.Join(d.directory, "candidates.db")
|
|
initial, err := openStore(path)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := initial.Close(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
db, err := d.openWriteDB(d)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer db.Close()
|
|
tx, err := db.Begin()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
id, err := insertStrategyCandidate(tx, "googlevideo", []string{"rr1---sn-alpha.googlevideo.com"}, managedGooglevideoArgs, nil)
|
|
if err != nil {
|
|
_ = tx.Rollback()
|
|
t.Fatal(err)
|
|
}
|
|
if err := tx.Commit(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
c, err := readStrategyCandidate(db, id)
|
|
if err != nil || c.Qualified {
|
|
t.Fatalf("experimental definition must remain unqualified: %+v %v", c, err)
|
|
}
|
|
t.Setenv("ZAPRET_AUTOTUNE_DB", path)
|
|
history, err := managedDependencies(nil).openDB()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer history.Close()
|
|
if _, err := history.Exec("CREATE TABLE managed_readonly_probe(value INTEGER)"); err == nil {
|
|
t.Fatal("ordinary managed history became writable")
|
|
}
|
|
if _, err := readStrategyCandidate(history, id); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestManagedCandidateWriterRejectsUnsafeStoreBeforeMutation(t *testing.T) {
|
|
for _, suffix := range []string{"", "-wal", "-shm", "-journal"} {
|
|
for _, kind := range []string{"wrong-path", "symlink", "hardlink", "mode", "owner", "directory"} {
|
|
t.Run(suffix+"/"+kind, func(t *testing.T) {
|
|
d, env := managedWriterFixture(t)
|
|
path := filepath.Join(d.directory, "candidates.db"+suffix)
|
|
outside := filepath.Join(t.TempDir(), "unrelated")
|
|
data := []byte("operator-owned bytes; never migrate or chmod")
|
|
if err := os.WriteFile(outside, data, 0640); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.WriteFile(path, data, 0600); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
switch kind {
|
|
case "wrong-path":
|
|
env["ZAPRET_AUTOTUNE_DB"] = outside
|
|
case "symlink", "hardlink", "directory":
|
|
if err := os.Remove(path); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var err error
|
|
if kind == "symlink" {
|
|
err = os.Symlink(outside, path)
|
|
} else if kind == "hardlink" {
|
|
err = os.Link(outside, path)
|
|
} else {
|
|
err = os.Mkdir(path, 0700)
|
|
}
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
case "mode":
|
|
if err := os.Chmod(path, 0640); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
case "owner":
|
|
if os.Geteuid() != 0 {
|
|
t.Skip("wrong-UID fixture requires root")
|
|
}
|
|
if err := os.Chown(path, 1, -1); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
before, err := os.Lstat(path)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
outsideBefore, err := os.Stat(outside)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if db, err := d.openWriteDB(d); err == nil {
|
|
_ = db.Close()
|
|
t.Fatal("unsafe writer accepted")
|
|
}
|
|
after, err := os.Lstat(path)
|
|
if err != nil || !os.SameFile(before, after) || before.Mode() != after.Mode() || before.Sys().(*syscall.Stat_t).Uid != after.Sys().(*syscall.Stat_t).Uid {
|
|
t.Fatal("unsafe file mutated", err)
|
|
}
|
|
outsideAfter, err := os.Stat(outside)
|
|
if err != nil || !os.SameFile(outsideBefore, outsideAfter) || outsideBefore.Mode() != outsideAfter.Mode() {
|
|
t.Fatal("unrelated file mutated", err)
|
|
}
|
|
for _, p := range []string{outside, path} {
|
|
if p == path && kind == "directory" {
|
|
continue
|
|
}
|
|
b, err := os.ReadFile(p)
|
|
if err != nil || !bytes.Equal(b, data) {
|
|
t.Fatal("file contents changed", err)
|
|
}
|
|
}
|
|
if suffix != "" {
|
|
if _, err := os.Lstat(filepath.Join(d.directory, "candidates.db")); !os.IsNotExist(err) {
|
|
t.Fatal("guard created database before rejecting sidecar", err)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
}
|